Repository navigation
fix(deps): pin idna to 3.18, the last release with transitional processing - #356
Merged
Merged
Conversation
…ssing idna 3.19 turns uts46_remap(transitional=True) into a no-op, so IDNAProcessor silently stops mapping e.g. faß.de to fass.de for the TLDs it treats as transitional. The floor of 3.19 (#335, unreleased) has kept every build red since; the released >=3.18 already lets fresh installs resolve to 3.20. Registries have not converged on one IDNA standard, so the SDK keeps that behaviour. Refs: RSRMID-3125
Refs: RSRMID-3125
Contributor
Author
|
🎉 This PR is included in version 5.0.9 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: RSRMID-3125. Supersedes #355, which pinned one version too late.
From idna 3.19 (2026-08-18),
uts46_remap(transitional=True)is deprecated and ignored. 3.18 still applies deviation mapping.IDNAProcessorrelies on it for the TLDs it treats as transitional, so with 3.19 or laterfaß.deencodes asxn--fa-hia.deinstead offass.de, andtests/test_idnaconverter.pyfails.idna>=3.19, merged 2026-09-17) has kept every PR build and the master Release run red since. It was never released.idna>=3.18with no upper bound, so fresh installs already resolve to 3.20 and lose transitional processing. This fix needs to be released.Registries have not converged on one IDNA standard (2003, 2008, UTS #46), so the SDK keeps its per-TLD transitional behaviour:
fix(deps): pinidna>=3.18,<3.19. This triggers a release.ci(dependabot): ignore idna>=3.19. fix(deps): update idna requirement from >=3.19 to >=3.20 #347 (idna 3.20) gets closed once this merges.🤖 Generated with Claude Code