Skip to content

chore: gradle plugin housekeeping #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hurali97 merged 2 commits into from
Feb 24, 2026
+1 −3
Merged

chore: gradle plugin housekeeping #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddde0ec
chore: remove obsolete ArtifactMatcher in gradle plugin
artus9033 Feb 23, 2026
156341a
chore: fix missing space in log
artus9033 Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ct/brownfield/src/main/kotlin/com/callstack/react/brownfield/expo/ExpoPublishingHelper.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ open class ExpoPublishingHelper(val brownfieldAppProject: Project) {
@Suppress("UNCHECKED_CAST")
(json["variants"] as? List<MutableMap<String, Any>>)?.forEach { variant ->
Logging.log(
"Injecting dependency to Gradle module JSON for variant" +
"Injecting dependency to Gradle module JSON for variant " +
"'${variant["name"]}': ${dependencyToAdd.groupId}:" +
"${dependencyToAdd.artifactId}:${dependencyToAdd.version}",
)
Expand Down
2 changes: 0 additions & 2 deletions ...ugins/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/shared/Constants.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,6 @@ object Constants {
ArtifactMatcher(groupId = StringMatcher.literal("host.exp.exponent")),
ArtifactMatcher(groupId = StringMatcher.literal("BareExpo")),
ArtifactMatcher(groupId = StringMatcher.regex("expo.*")),
// below: groupId of the local Expo app itself that may be referenced by some of the Expo packages
ArtifactMatcher(groupId = StringMatcher.literal("ExpoApp")),
// below: a broken transitive dependency that has no version specified and thus breaks the build
ArtifactMatcher(
groupId = StringMatcher.literal("org.jetbrains.kotlin"),
Expand Down
Loading