Skip to content

Comments

chore: gradle plugin housekeeping#249

Merged
hurali97 merged 2 commits intomainfrom
chore/gradle-plugin-housekeeping
Feb 24, 2026
Merged

chore: gradle plugin housekeeping#249
hurali97 merged 2 commits intomainfrom
chore/gradle-plugin-housekeeping

Conversation

@artus9033
Copy link
Collaborator

Summary

This PR removes an obsolete ArtifactMatcher and fixes a typo in log message in the Gradle plugin.
The matcher is obsolete since it uses a hardcoded project group name of ExpoApp, which may be changed in app.json; it seems to have always been obsolete since the actual logic that performs the duty agnostically of the project name is present in ExpoPublishingHelper::shouldExcludeDependency, which excludes root project dependencies.

Test plan

@artus9033 artus9033 requested a review from hurali97 February 23, 2026 23:16
@artus9033 artus9033 self-assigned this Feb 23, 2026
Copilot AI review requested due to automatic review settings February 23, 2026 23:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs minor housekeeping in the brownfield Gradle plugin by removing an obsolete Expo artifact blacklist entry and fixing a log message typo to improve readability.

Changes:

  • Removed the hardcoded ExpoApp ArtifactMatcher entry from the Expo transitive dependency artifact blacklist.
  • Fixed a missing whitespace in the “Injecting dependency…” log line when modifying Gradle module metadata.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
gradle-plugins/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/shared/Constants.kt Removes the obsolete hardcoded ExpoApp artifact blacklist entry.
gradle-plugins/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/expo/ExpoPublishingHelper.kt Fixes a log message formatting typo by adding the missing space.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hurali97 hurali97 merged commit 6ea8da9 into main Feb 24, 2026
12 of 13 checks passed
@hurali97 hurali97 deleted the chore/gradle-plugin-housekeeping branch February 24, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants