Conversation
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
All reported issues were addressed across 33 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
This PR is ready at 0780e5e. All 14 checks pass, and bundle size grows by +1.1 kB unpacked, under the 3 kB threshold. There are no conflicts. I did not rerun the focused tests or the planted mutations, and I judged mutation sensitivity by reading the base code paths. I also did not check whether the fence state that createNextFence mints leaves anything behind on the now-refused start paths. I read only enough to see that it is in-memory. The base is fix/session-capture-finish (#3137), so this review covers only the delta from 1376a9e. Please merge #3137 first. After that, only the notes below remain. Not blocking, and you can take or leave these: the same admission check ( |
Summary
Follow-up to #3133–#3137 for #3116. Daemon test cleanup stops independently observed children even with corrupt metadata, joins registered successors, and locks registration before deleting a directory. Timeout diagnostics distinguish retained metadata from a process that survived.
Capture bindings retain their own adopted handle after retirement. Cleanup refreshes only the same lifetime before a lazy import; native starts refuse closed admission. The shared fixtures now model lifetime and fence identity. Three capture field adapters live with their binding, fixing the eager-import CI regression.
flowchart LR R[Captured lifetime] --> B[Capture binding] B --> H[Owned handle] B --> C{Current lifetime and fence match?} C -->|Yes| U[Update matching slot] C -->|No| K[Preserve successor]Validation
Head:
0780e5e4c6. 33 changed files; 126 focused tests pass without skips. Ten planted regressions failed, then restored green. All 757 global import-budget tests pass. Lint, typecheck and changed-code Fallow pass. Independent read-only audit found no actionable issues.All locally runnable affected checks pass; platform/device CI remains GitHub-authoritative.