You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Session directory and app-log paths now come from the existing artifact-path module. Stale-claim recovery resolves paths from the dead owner's state directory directly, without constructing a session store. Store consumers delegate to the same validated functions.
Removes the SessionStore.expandHome forwarder and migrates all nine production callers to expandSessionPath. Path sanitization, errors, filenames and cwd handling are preserved. Moves the existing path tests to their defining modules, retaining their assertions.
Depends on #3133. Ref #3116. Ten files, 191 gross changed lines.
Validation
Tested 64f40ac3bf5b081a98b09b204bf72a482c8d3a7d:
38 focused tests pass across four files; zero skips.
Quick checks and Fallow pass.
Exact-head affected checks pass: 388 files, 2,709 related tests; zero skips.
Independent read-only audit confirms preserved path validation/layout, recorded-owner recovery scope, complete caller migration and test discovery. No findings.
CI-owned coverage and provider checks remain pending.
This PR is ready at 64f40ac. The code looks right, and the moved tests keep their assertions. All 14 checks pass, and there are no conflicts. It waits only on its base, #3133, landing. Not blocking, and you can take or leave these: device-claim-reconciliation.ts line 28 still joins safeSessionName(claim.session) itself, so it skips the empty, . and .. refusal in resolveSessionDir, and durable-capture-resource.ts line 58 does the same from a package that cannot import src/daemon, so a follow-up could route the first through resolveSessionDir and inject it into capture-kit; the doc on isSafeSessionSegment still names SessionStore.resolveSessionDir, and it should point at resolveSessionDir in session-artifact-paths.ts. I did not run the tests, and I read the #3138 follow-up only through your comment, not its diff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ready-for-humanValid work that needs human implementation, judgment, or maintainer merge
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Session directory and app-log paths now come from the existing artifact-path module. Stale-claim recovery resolves paths from the dead owner's state directory directly, without constructing a session store. Store consumers delegate to the same validated functions.
Removes the
SessionStore.expandHomeforwarder and migrates all nine production callers toexpandSessionPath. Path sanitization, errors, filenames and cwd handling are preserved. Moves the existing path tests to their defining modules, retaining their assertions.Depends on #3133. Ref #3116. Ten files, 191 gross changed lines.
Validation
Tested
64f40ac3bf5b081a98b09b204bf72a482c8d3a7d: