Repository navigation
Conversation
…hex-encode from a table
…st through the #[cachekit] key path
…n the #[cachekit] key path
…est error kind for the unreachable hex branch
Conflicts in README.md and examples/bench_hot_path.rs: this branch adds the macro_hit op, main adds the ns and nsenc modes. Both kept. The union also paired macro_hit with ns and nsenc, and those cases fail: a namespaced client refuses interop reads. is_case now leaves them out, so every listed case runs.
The perf-ir job built both trees with default features, which leave out macros, so a bench case behind #[cfg(feature = "macros")] never reached the gate. Build head and base with --features macros; the feature exists at every base the job uses, including the last release tag.
…nto lab-12228-throwaway-stack-212 # Conflicts: # Makefile # README.md
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Instruction counts: PASS116 of 116 cases measured. A case fails when its median is slower than the base by its floor or more (SLOWER). The floor is 0.5%, and such a case also fails when the head's runs spread by more than that (NOISIER), except
104 cases within noise
PR head |
Contributor
Author
|
Verification run done (all 12 macro_hit cases measured, PASS); closing as planned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway, do not merge. #218 merged with the head of #212, only to get one Instruction counts vs base run in which both builds contain
macro_hit. Closed and its branch deleted once that run reports.