Repository navigation
feat(cachekitio): report L1 hit latency and add a telemetry off switch (LAB-12079) #691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,379
−45
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
ecf9f5f
feat(cachekitio): report L1 hit latency and add a telemetry off switch
27Bslash6 51f2d2c
fix(cachekitio): a forked child never reports its parent's L1 hits; t…
27Bslash6 160f2fe
fix(cachekitio): match CACHEKIT_TELEMETRY in any case; empty reports …
27Bslash6 73aa58c
refactor(cachekitio): the async timed call keeps the callee's result …
27Bslash6 86ac974
fix(cachekitio): child threads racing a hookless fork agree on one re…
27Bslash6 cfc0ee9
fix(cachekitio): the sampling draw no longer consumes the global rand…
27Bslash6 c6387bd
fix(cachekitio): a child forked from C reseeds the sampling draw at i…
27Bslash6 ebfd4c0
fix(cachekitio): a report built in a child forked from C reseeds the …
27Bslash6 cb78a7f
fix(cachekitio): redraw the timed hit that reseeds a C-forked child's…
27Bslash6 1f4a905
fix(cachekitio): drop the reseed redraw; seed the measured workload's…
27Bslash6 e34f0cc
Merge remote-tracking branch 'origin/main' into agent/irving/lab-1207…
27Bslash6 a3399c1
fix(cachekitio): a child's report takeover keeps a state published by…
27Bslash6 f227bd3
Merge remote-tracking branch 'origin/main' into agent/irving/50330bc1…
27Bslash6 5454f2d
perf(telemetry): record the timed L1 hit in place and time one call i…
27Bslash6 b8865c1
fix(telemetry): keep a failing latency record from demoting the L1 hit
27Bslash6 3c3ccda
test(telemetry): check every bucket bound through the report's own count
27Bslash6 7232a66
fix(telemetry): store a report's sum only after its bucket is counted
27Bslash6 b6353f1
docs(telemetry): an empty CACHEKIT_TELEMETRY is unset; re-record l1_h…
27Bslash6 0a14956
docs(telemetry): the session id carries the function name; durations …
27Bslash6 4c03714
Merge remote-tracking branch 'origin/main' into agent/irving/50330bc1…
27Bslash6 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.