refactor(eol): define lifecycle semantics in YAML#63
Merged
bakayolo merged 1 commit intoblock:mainfrom Apr 29, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
bakayolo
force-pushed
the
fix/lambda-deprecated-support-yellow
branch
from
ab9b1a9 to
5e842bf
Compare
bakayolo
changed the title
bakayolo
changed the title
Kiran01bm
approved these changes
Apr 29, 2026
Merged
Kiran01bm
added a commit
that referenced
this pull request
Apr 30, 2026
## What and Why ? The `add-version-guard-resource` skill was added in #33 and only had two incidental touches since (#57, #63), but ~10 intervening PRs changed the formats / schemas / workflows it teaches. Walked the skill end-to-end against current `resources.yaml` + `loader.go` and fixed every staleness an agent would hit today. Markdown-only. No code changes. ## Fixes | Spot | Was | Now | |------|-----|-----| | `SKILL.md` Step 1 (no-product STOP) | Stop on any missing product | Fall back to upstream product when AWS-flavored is missing (Valkey / Memcached pattern from #53); only stop if no product exists at all | | `SKILL.md` Step 3 (`native_type_pattern` examples) | `rds/AmazonAurora*/cluster`, `eks/Cluster`, `elastiCache/*/cluster` | Actual current patterns from `resources.yaml` + note that `*` only matches whole path segments (partial-segment globs silently match nothing) | | `SKILL.md` Step 4 (schema overview) | Standard = 3 fields; declarative = "EKS only" | Three real cycle shapes the standard adapter handles; declarative covers EKS *and* Lambda; inline lifecycle block; full field/action set incl. `supported`; accurate loader behavior (loader auto-fills `schema: declarative` when `lifecycle:` is present) | | `SKILL.md` Step 6 (OpenSearch example) | `native_type_pattern: "opensearch/Domain"` | `"elasticSearchService\|OpenSearch Domain"` (old value matched zero rows) | | `SKILL.md` Step 6 (examples menu) | `elasticache.yaml` = "wildcard patterns" | Per-engine split (#53); the example file itself warns against wildcard + single product | | `SKILL.md` Completion | Steered toward Go adapter | Steers toward declarative YAML; Go adapter is now exceptional (#63) | | `references/troubleshooting.md` ("Non-Standard Schema") | `schema: {resource}-adapter` + "refer to EKS adapter" | `schema: declarative` + `lifecycle:` block, link to `ADAPTERS.md`; EKS Go adapter no longer exists | | `SKILL.md` Step 7 footer | "Proceed to Step 7" | "Proceed to Step 8" | ## Driving PRs since #33 #36, #38, #42, #44, #45, #53, #54, #56, #62, #63.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Some products use the same endoflife.date fields differently. EKS has no true EOL but does have an unsupported-after boundary. Lambda has a deprecated-support window but no extendedSupport field. Encoding every one-off as a Go adapter does not scale. This makes those differences explicit in YAML, similar to the existing inventory transform model.
Verification
Deployment