Skip to content

test(desktop): stabilize keyboard community reorder #4652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kiranmagic7 wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −0
Open

test(desktop): stabilize keyboard community reorder #4652

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions desktop/tests/e2e/community-rail.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -986,8 +986,24 @@ test.describe("community rail", () => {
}),
);
}, `community-rail-button-${COMMUNITY_B.id}`);

// KeyboardSensor attaches its document keydown listener on the next timer
// tick. Wait for dnd-kit to expose the active drag before sending ArrowUp.
await expect(buttonB).toHaveAttribute("aria-pressed", "true");

// ArrowUp moves the active item one slot up.
await page.keyboard.press("ArrowUp");

// Let dnd-kit publish the new collision target before dropping. Otherwise
// the drop can still observe B's original position and become a no-op.
await expect
.poll(async () => {
const boxA = await buttonA.boundingBox();
const boxB = await buttonB.boundingBox();
return boxA !== null && boxB !== null && boxB.y < boxA.y;
})
.toBe(true);

// Space drops the item — same synthetic dispatch for consistency.
await page.evaluate((testId) => {
const el = document.querySelector(`[data-testid="${testId}"]`);
Expand Down