test(desktop): stabilize keyboard community reorder - #4652
Open
kiranmagic7 wants to merge 1 commit into
Open
Conversation
Signed-off-by: kiranmagic7 <262980978+kiranmagic7@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Synchronize the keyboard-reorder test with dnd-kit's observable drag lifecycle.
KeyboardSensorattaches its document keydown listener on the next timer tick, so the test could sendArrowUpbefore the sensor was ready. The drop could also race the updated collision target and preserve the original order.The test now waits for pickup and for B to move above A before dropping. Product behavior is unchanged.
Related issue
Fixes #4530.
Testing
On unmodified
upstream/main, the issue reproduction produced 6 first-attempt failures out of 20; all retries passed.With this patch, the same command passed 20/20 without retries:
just ciScreenshots are not applicable; this is a test-only change.