Conversation
Issue #43 asks what a port owes a reader who already uses the thing it reimplements. Attribution, the name collision and the shared cache all landed. The community health files did not, and their absence is the part a prospective adopter notices first: no CONTRIBUTING, no SECURITY, no issue templates, so every report arrives shaped however the reporter guessed. For this project that shape matters more than usual. The single most valuable thing anyone can send is a divergence report -- upstream does X, this does Y, both commands, both outputs -- because it is the one class of bug the project cannot find for itself. So the divergence template is the primary one and asks for exactly that pair, and both CONTRIBUTING and the issue chooser say plainly that a feature upstream lacks belongs on upstream's tracker, not here. SECURITY draws the line where it actually falls for a hook runner: the tool downloads and executes code by design, so the boundary is whose code and whether it can be made to run something unasked -- checksum verification in the action, path handling in the store, config parsing. A hostile entry in your own config is not a vulnerability in the runner. Also fixes a dead link. docs/parity.md offered test/integration/parity_report.json as the evidence behind the parity number, but that path is gitignored -- the file is generated, and CI uploads it as an artifact. A doc whose whole argument is "this is measured, not remembered" cannot point at a 404, so it now points at the artifact that exists. Refs #43
16 of 19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the launch-readiness work in #43. Attribution, the name collision and the shared-cache warning already landed; the community health files did not, and their absence is what a prospective adopter notices first.
What this adds
CONTRIBUTING.mdSECURITY.mdCODE_OF_CONDUCT.md.github/ISSUE_TEMPLATE/divergence.ymlis the primary template and asks for two commands and two outputs. Plusbug.yml,language.yml(pointed at the ten untested backends), and aconfig.ymlchooser that routes feature requests upstream and security reports to private advisories..github/PULL_REQUEST_TEMPLATE.mdmake checkdoes not run lint.Also: a dead link in the parity docs
docs/parity.mdofferedtest/integration/parity_report.jsonas the evidence behind the 78/78 number, but that path is in.gitignore— the report is generated, and CI uploads it as theparity-reportartifact. A document whose entire argument is this is measured, not remembered cannot point at a 404, so it now points at the artifact that exists.Verification
pre-commit run --all-filespasses, includinggolangci-lintandcheck-yaml; all four issue-template YAML files parse.Refs #43