fix!: change auth_delay to return u8#64
Merged
notmandatory merged 1 commit intomasterfrom Apr 7, 2026
Merged
Conversation
c0c64d9 to
e0afe8c
Compare
8 tasks
e0afe8c to
9af8875
Compare
API BREAKING change.
9af8875 to
257ac57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes the return value for
auth_delayfrom ausizeto au8. The value will never be more than 15 so au8is more appropriate and can be cleanly exposed via FFI.Notes to the reviewers
This is an API BREAKING change.
I manually tested this change with physical TAPSIGNER, SATSCARD, and SATSCHIP cards via the CLI.
I also removed an unneeded ref return from auth_delay since the type
Option<u8>implements the Copy trait.Changelog notice
usizeto au8. API BREAKING.Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: