refactor(ffi): expose satscard stepwise wait via wait#63
Merged
notmandatory merged 3 commits intobitcoindevkit:masterfrom Apr 8, 2026
Merged
refactor(ffi): expose satscard stepwise wait via wait#63notmandatory merged 3 commits intobitcoindevkit:masterfrom
notmandatory merged 3 commits intobitcoindevkit:masterfrom
Conversation
Collaborator
Author
|
rebase on #64 and pull in changes |
Member
|
After #64 should be able to just expose the existing |
notmandatory
approved these changes
Apr 7, 2026
Member
notmandatory
left a comment
There was a problem hiding this comment.
ACK c91b137
I'd prefer to have the same wait FFI function for all three cards but if you need this now go ahead and merge it. I don't mind doing a followup PR for the other card types.
Collaborator
Author
PR updated to add satschip and tapsigner, in 2 new commits |
notmandatory
approved these changes
Apr 8, 2026
Member
notmandatory
left a comment
There was a problem hiding this comment.
ACK 492ae4c
Thanks for updating the other card types!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the SATSCARD FFI
waitAPI to expose the card's existing one-second auth delay step directly, returning the remaining delay after each call. That lets clients render cooldown progress one second at a time instead of estimating locally.The immediate motivation is SatsBuddy PR #139, which added a UI countdown for SATSCARD cooldown recovery during send/sign. That PR is good enough for now on the app side, and this PR is the upstream follow-up that exposes a cleaner stepwise primitive for that flow.
Notes to the reviewers
This is intentionally scoped to SATSCARD only for now, since that is the current consumer. If we want the same API on TAPSIGNER or SATSCHIP, that can follow in a separate PR.
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: