Extract the sprite material cache to a separate struct - #25498
Open
cookie1170 wants to merge 2 commits into
Open
Extract the sprite material cache to a separate struct#25498cookie1170 wants to merge 2 commits into
cookie1170 wants to merge 2 commits into
Conversation
cookie1170
force-pushed
the
extract-sprite-material-cache
branch
from
August 21, 2026 00:27
468d7e2 to
fc27f1d
Compare
cookie1170
force-pushed
the
extract-sprite-material-cache
branch
from
August 21, 2026 00:38
fc27f1d to
81b7731
Compare
Zeophlite
added
A-Rendering
Zeophlite
approved these changes
Aug 21, 2026
IceSentry
reviewed
Aug 21, 2026
IceSentry
approved these changes
Aug 21, 2026
IceSentry
added
S-Ready-For-Final-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Extract the sprite material cache to a separate struct for reuse and testing. Prerequisite to #25415
Solution
Make a (generic, because of #25415)
SpriteMaterialCachestruct which stores the previouslyLocal<>hash maps required for caching the materialsTesting
Added unit tests in
bevy_sprite_render::sprite_mesh