Skip to content

Migrate anisotropy to feathers - #25494

Draft
tevans-3 wants to merge 7 commits into
bevyengine:mainfrom
tevans-3:25032_migrate_anisotropy
Draft

Migrate anisotropy to feathers#25494
tevans-3 wants to merge 7 commits into
bevyengine:mainfrom
tevans-3:25032_migrate_anisotropy

Conversation

@tevans-3

Copy link
Copy Markdown
Member

Objective

Addresses one part of #25032

Solution

  • Switch the 3d/anisotropy.rs example to use Feathers checkboxes and radios
  • Refactor the checkbox helper to accept an "IsChecked" flag and spawn both checked and unchecked variants (the previous version only let callers create unchecked boxes; I think this caused some mild awkwardness for Migrate bloom_2d to use Feathers. #25431).
  • The checkbox refactor was necessary here because anisotropy is turned on by default, but the previous helper only allowed callers to create unchecked boxes, so to a user it looked like anisotropy was toggled off even though it was actually on
  • Updated the other users of checkbox.rs (2d_shapes.rs and the pending Migrate 3d_shapes to feathers #25436) to pass IsChecked to the helper

Because the checkbox refactor touches #25436, that PR blocks this one.

Testing

cargo run --example anisotropy --features="bevy_feathers jpeg pbr_anisotropy_texture"

I also tested the other callers of feathers_option_checkbox and verified that they still work with the refactor.

anisotropy.mp4

@tevans-3 tevans-3 added S-Blocked This cannot move forward until something else changes A-UI Graphical user interfaces, styles, layouts, and widgets labels Aug 20, 2026
@github-project-automation github-project-automation Bot moved this to Needs SME Triage in UI Aug 20, 2026
@tevans-3 tevans-3 added D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 20, 2026
@tevans-3

Copy link
Copy Markdown
Member Author

the current CI failure is fixed by #25492

@tevans-3
tevans-3 force-pushed the 25032_migrate_anisotropy branch from a990935 to ce44b78 Compare August 21, 2026 01:59
@tevans-3
tevans-3 marked this pull request as draft August 21, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-UI Graphical user interfaces, styles, layouts, and widgets D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Blocked This cannot move forward until something else changes S-Needs-Review Needs reviewer attention (from anyone!) to move forward

Projects

Status: Needs SME Triage

Development

Successfully merging this pull request may close these issues.

1 participant