Refactor animation timers inside pan_orbit_camera - #25489
Conversation
taishi-sama
added
A-Camera
taishi-sama
changed the title
| )>, | ||
| mut event: MessageWriter<RequestRedraw>, | ||
| time: Res<Time>, | ||
| time: Res<Time<Real>>, |
There was a problem hiding this comment.
Definitely correct, and worth doing regardless of what else we decide.
There was a problem hiding this comment.
agreed, this was my feedback on the first PR!
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Okay, that was a nicer cleanup than I anticipated. I prefer this: random Instant::now calls are less idiomatic when we have no reason to use them. We're not even getting more input-aligned time stamps.
alice-i-cecile
added
C-Code-Quality
jbuehler23
left a comment
jbuehler23
left a comment
There was a problem hiding this comment.
overall, this is a step in the right direction and actually closer aligned to how we have built the editor camera for jackdaw too once exploring bevy_editor_cam
| )>, | ||
| mut event: MessageWriter<RequestRedraw>, | ||
| time: Res<Time>, | ||
| time: Res<Time<Real>>, |
There was a problem hiding this comment.
agreed, this was my feedback on the first PR!
alice-i-cecile
added
S-Ready-For-Final-Review
laundmo
left a comment
laundmo
left a comment
There was a problem hiding this comment.
LGTM. At some point we should consider if something like a camera LookTo animation should be using the animation system, but this PR isn't the place to discuss that.
6 participants
Closes #25469
Objective
Upstreamed version uses global
Instant::now()for timekeeping for some animations.Replace that logic with
Res<Time<Real>>andTimer