Skip to content

Feathers color plane shader imports fix - #25486

Merged
mockersf merged 5 commits into
bevyengine:mainfrom
ickshonpe:feathers-color-plane-shader-imports-fix
Aug 22, 2026
Merged

Feathers color plane shader imports fix#25486
mockersf merged 5 commits into
bevyengine:mainfrom
ickshonpe:feathers-color-plane-shader-imports-fix

Conversation

@ickshonpe

Copy link
Copy Markdown
Contributor

Objective

2026-08-20T13:12:53.161553Z ERROR bevy_render::render_resource::pipeline_cache: failed to process shader error:
\x1b[1m\x1b[91merror\x1b[0m\x1b[1m\x1b[97m: cannot find declaration of `okhsl_to_linear_rgb`\x1b[0m
  \x1b[1m\x1b[96m--> \x1b[0membedded://bevy_feathers/assets/shaders/color_plane.wesl:32:17
   \x1b[1m\x1b[96m|\x1b[0m
\x1b[1m\x1b[96m32\x1b[0m \x1b[1m\x1b[96m|\x1b[0m     return vec4(okhsl_to_linear_rgb(vec3(uv.x, uniform_data.fixed_channel, 1.0 - uv.y)), 1.0);
   \x1b[1m\x1b[96m|\x1b[0m                 \x1b[1m\x1b[91m^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\x1b[0m \x1b[1m\x1b[91mcannot find declaration of `okhsl_to_linear_rgb`\x1b[0m
   \x1b[1m\x1b[96m|\x1b[0m
   \x1b[1m\x1b[96m= \x1b[0m\x1b[1m\x1b[97mnote\x1b[0m: in declaration of `fragment` in bevy_feathers::assets::shaders::color_plane (embedded://bevy_feathers/assets/shaders/color_plane.wesl)

Solution

An okhsl_to_linear_rgb import is missing from color_plane.wesl. Added it.

@ickshonpe ickshonpe added C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy S-Needs-Review Needs reviewer attention (from anyone!) to move forward D-Shaders This code uses GPU shader languages P-Crash A sudden unexpected crash and removed P-Crash A sudden unexpected crash labels Aug 20, 2026
@Zeophlite

Copy link
Copy Markdown
Contributor

Looks like there's 2x separate fixes here, could you update the description?

@ickshonpe

ickshonpe commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

Looks like there's 2x separate fixes here, could you update the description?

Oh yeah sorry, that was a commit from a separate PR I must have included by accident.

@Zeophlite Zeophlite added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 21, 2026
@mockersf
mockersf enabled auto-merge August 22, 2026 18:51
@mockersf
mockersf disabled auto-merge August 22, 2026 18:51
@mockersf
mockersf enabled auto-merge August 22, 2026 18:51
@mockersf
mockersf added this pull request to the merge queue Aug 22, 2026
Merged via the queue into bevyengine:main with commit 4805ca7 Aug 22, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Bug An unexpected or incorrect behavior D-Shaders This code uses GPU shader languages D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants