Add a CI screenshot run for the tonemapping example - #25478
Open
stuartparmenter wants to merge 1 commit into
Open
Add a CI screenshot run for the tonemapping example#25478stuartparmenter wants to merge 1 commit into
stuartparmenter wants to merge 1 commit into
Conversation
Zeophlite
approved these changes
Aug 20, 2026
Contributor
Author
|
I would also be fine removing this once I finish making my way through all the PRs, or we can skip it entirely if people prefer keeping CI lighter |
Member
|
This example doesn't work on Windows in CI |
cookie1170
approved these changes
Aug 20, 2026
Contributor
Author
weird, I'll try to debug why it is running out of memory |
Member
|
It would probably be easier to add a simple testbed that use less memory? Anyway using a testbed for regressions would be better than using the example in CI |
alice-i-cecile
approved these changes
Aug 20, 2026
Member
|
Putting something like this into the testbed makes more sense, agreed. |
Contributor
Author
|
thanks, I'll review a few options here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
The
tonemappingexample never runs in CI, and it's the most direct coverage for upcoming tonemapping render-path work.Solution
Add the tonemapping example to the Pixel Eagle tests.
Testing
Tested locally with lavapipe to validate the run and the screenshot.
This PR was built by me with the assistance of Claude Code w/ Fable 5