Skip to content

Add a CI screenshot run for the tonemapping example - #25478

Open
stuartparmenter wants to merge 1 commit into
bevyengine:mainfrom
stuartparmenter:hdr-wave2-testbed-screenshots
Open

Add a CI screenshot run for the tonemapping example#25478
stuartparmenter wants to merge 1 commit into
bevyengine:mainfrom
stuartparmenter:hdr-wave2-testbed-screenshots

Conversation

@stuartparmenter

Copy link
Copy Markdown
Contributor

Objective

The tonemapping example never runs in CI, and it's the most direct coverage for upcoming tonemapping render-path work.

Solution

Add the tonemapping example to the Pixel Eagle tests.

Testing

Tested locally with lavapipe to validate the run and the screenshot.


This PR was built by me with the assistance of Claude Code w/ Fable 5

@stuartparmenter stuartparmenter added A-Rendering Drawing game state to the screen C-Testing A change that impacts how we test Bevy or how users test their apps D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 20, 2026
@github-project-automation github-project-automation Bot moved this to Needs SME Triage in Rendering Aug 20, 2026
@Zeophlite
Zeophlite requested a review from mockersf August 20, 2026 05:15
@stuartparmenter

Copy link
Copy Markdown
Contributor Author

I would also be fine removing this once I finish making my way through all the PRs, or we can skip it entirely if people prefer keeping CI lighter

@mockersf

Copy link
Copy Markdown
Member

This example doesn't work on Windows in CI

     Running `target\release\examples\tonemapping.exe`
2026-08-20T03:46:08.901828Z  INFO bevy_diagnostic::system_information_diagnostics_plugin::internal: SystemInfo { os: "Windows Server 2025 Datacenter", kernel: "26100", cpu: "AMD EPYC 7763 64-Core Processor", core_count: "2", memory: "16.0 GiB" }
2026-08-20T03:46:09.024235Z  INFO bevy_render::renderer: AdapterInfo { name: "Microsoft Basic Render Driver", vendor: 5140, device: 140, device_type: Cpu, device_pci_bus_id: "", driver: "10.0.26100.33158", driver_info: "", backend: Dx12, subgroup_min_size: 4, subgroup_max_size: 4, transient_saves_memory: Some(false), limit_bucket: None }
2026-08-20T03:46:09.024302Z  WARN bevy_render::renderer: The selected adapter is using a driver that only supports software rendering. This is likely to be very slow. See https://bevy.org/learn/errors/b0006/
2026-08-20T03:46:09.186623Z  INFO bevy_pbr::cluster: GPU clustering is supported on this device.
2026-08-20T03:46:09.186744Z  INFO bevy_render::batching::gpu_preprocessing: GPU preprocessing is fully supported on this device.
2026-08-20T03:46:09.187670Z  INFO bevy_winit::system: Creating new window tonemapping (67v0)
2026-08-20T03:50:57.985322Z  INFO bevy_dev_tools::ci_testing::systems: Took a screenshot at frame 400.
2026-08-20T03:53:34.951689Z ERROR bevy_render::error_handler: Caught DeviceLost error: Unknown Out of memory
2026-08-20T03:53:34.951759Z ERROR bevy_render::error_handler: Caught rendering error: Out of Memory
2026-08-20T03:53:34.953689Z ERROR bevy_render::error_handler: Caught rendering error: Validation Error

Caused by:
  In Buffer::map_async
    Buffer with 'clustering metadata staging buffer' label is invalid

2026-08-20T03:53:34.954013Z ERROR bevy_render::error_handler: Quitting the application due to DeviceLost RenderError

@stuartparmenter

Copy link
Copy Markdown
Contributor Author

This example doesn't work on Windows in CI

weird, I'll try to debug why it is running out of memory

@mockersf

Copy link
Copy Markdown
Member

It would probably be easier to add a simple testbed that use less memory?

Anyway using a testbed for regressions would be better than using the example in CI

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 20, 2026
@alice-i-cecile alice-i-cecile added S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Aug 20, 2026
@alice-i-cecile

Copy link
Copy Markdown
Member

Putting something like this into the testbed makes more sense, agreed.

@stuartparmenter

Copy link
Copy Markdown
Contributor Author

thanks, I'll review a few options here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Testing A change that impacts how we test Bevy or how users test their apps D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged

Projects

Status: Needs SME Triage

Development

Successfully merging this pull request may close these issues.

5 participants