Stop rendering escaped ANSI sequences in wesl errors - #25464
Open
dylansechet wants to merge 2 commits into
Open
Conversation
alice-i-cecile
approved these changes
Aug 19, 2026
k2d222
approved these changes
Aug 19, 2026
alice-i-cecile
enabled auto-merge
August 19, 2026 17:49
BenjaminBrienen
approved these changes
Aug 19, 2026
alice-i-cecile
disabled auto-merge
August 19, 2026 20:54
alice-i-cecile
enabled auto-merge
August 19, 2026 20:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Wesl shaders print escaped ANSI sequences when hitting a shader processing error. The same bug used to be present for wgsl and had to be fixed in
naga_oil(#21164).Solution
Same approach as for #21164, disable color rendering.
Testing
Loaded a shader with errors and the error log is readable now :)