Fix ScrollArea scroll speed#24620
Open
Cannedfood wants to merge 1 commit into
Open
Conversation
When scrolling a ScrollArea, the scroll delta (in lines) was added to the scroll position (logical pixels). This made scrolling with a physical mouse feel extremely slow (3-4px per click, depending on OS settings). This PR fixes the conversion
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide, as well as our policy regarding AI usage, and we look forward to reviewing your pull request shortly ✨ |
kfc35
added
C-Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When scrolling a ScrollArea, the scroll delta (in lines) was added to the scroll position
(in logical pixels).
This unit error made scrolling extremely slow when
scroll.unit == Line.Testing
I scrolled the lists in the demo with a touchpad (emits scroll.unit == Line), but unfortunately did not find a device that emits the scroll delta in pixels.
cargo run --release --example feathers_gallery --features=bevy_feathers