fix: text selection collapse on focus loss#24619
Open
zen-zap wants to merge 3 commits into
Open
Conversation
Signed-off-by: zen-zap <pandaashutosh340@gmail.com>
Signed-off-by: zen-zap <pandaashutosh340@gmail.com>
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide, as well as our policy regarding AI usage, and we look forward to reviewing your pull request shortly ✨ |
kfc35
added
A-UI
kfc35
added
D-Straightforward
kfc35
reviewed
Jun 14, 2026
kfc35
left a comment
kfc35
left a comment
Contributor
There was a problem hiding this comment.
The fix works, thanks! Just a comment to simplify this even further.
| mut editable_text_query: Query<&mut EditableText>, | ||
| ) { | ||
| if let Ok(mut editable_text) = editable_text_query.get_mut(trigger.entity) { | ||
| editable_text.queue_edit(TextEdit::CollapseSelection); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Signed-off-by: zen-zap <pandaashutosh340@gmail.com>
kfc35
approved these changes
Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
multiline_text_inputexample: The numeric input's colors are wrong after navigation #24579.EditableTextwidget lost focus when pressingTab, the text selection was preserved internally. This left the text permanently in the selection styling (black). This PR ensures it reverts to the default styling once focus is lost.Solution
on_focus_lost_collapse_selectionobserver to theEditableTextInputPlugin.FocusLostevent is triggered, it queues anTextEdit::CollapseSelectionaction on the widget as well.Testing
multiline_text_input).Before:
After: