light: add SunDisk::MARS preset for Mars atmosphere#24618
Open
da-x wants to merge 2 commits into
Open
Conversation
This commit introduces a new `SunDisk::MARS` constant to accurately represent the sun’s apparent size when viewed from Mars. The implementation updates the documentation and adds the corresponding constant with an angular size of ~21 arcminutes (0.00615 radians). Key modifications: - Added `SunDisk::MARS` constant in `directional_light.rs` - Updated documentation to reference the new Mars preset - Modified `atmosphere` example to switch sun disk alongside atmosphere presets
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide, as well as our policy regarding AI usage, and we look forward to reviewing your pull request shortly ✨ |
alice-i-cecile
added
A-Rendering
alice-i-cecile
approved these changes
Jun 13, 2026
mate-h
approved these changes
Jun 13, 2026
mate-h
left a comment
mate-h
left a comment
Contributor
There was a problem hiding this comment.
Looks good thanks for this improvement, just a small nit :)
kfc35
added
S-Ready-For-Final-Review
Co-authored-by: Máté Homolya <mate.homolya@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the atmosphere example we can change between Earth and Mars, but the size of the sun does not change. This somewhat bothered me from an astronomical accuarcy.
This commit introduces a new
SunDisk::MARSconstant to accurately represent the sun’s apparent size when viewed from Mars. The implementation updates the documentation and adds the corresponding constant with an angular size of ~21 arcminutes (0.00615 radians).Key modifications:
SunDisk::MARSconstant indirectional_light.rsatmosphereexample to switch sun disk alongside atmosphere presetsI tested this manually.