Diagnostic overlay fixes and improvements#24611
Open
cart wants to merge 2 commits into
Open
Conversation
cart
added
C-Bug
BenjaminBrienen
approved these changes
Jun 12, 2026
MrGVSV
approved these changes
Jun 12, 2026
kfc35
reviewed
Jun 12, 2026
jbuehler23
reviewed
Jun 12, 2026
|
|
||
| /// Configures the style of diagnostic overlays | ||
| #[derive(Resource)] | ||
| pub struct DiagnosticsOverlayStyle { |
Contributor
There was a problem hiding this comment.
just a question generally really from my end - but why not use a feathers widget for this?
Member
Author
There was a problem hiding this comment.
To avoid adding a feathers/scene dependency. Keeps things slim / lets people that want to exclude these features do so.
Co-authored-by: Kevin Chen <chen.kevin.f@gmail.com>
kfc35
added
the
S-Ready-For-Final-Review
cookie1170
approved these changes
Jun 13, 2026
dloukadakis
approved these changes
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
The new Diagnostic Overlay has some issues:
Solution
Fix all of those things.
This should ship in 0.19 because it is pretty broken without the click passthrough fix. This doesn't need an RC to test because it is a new feature, very broken without this fix, and it is disabled by default.