Skip to content

Text pipeline update buffer spans refactor #22394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alice-i-cecile merged 2 commits into from
Jan 6, 2026
Merged

Text pipeline update buffer spans refactor #22394

alice-i-cecile merged 2 commits into from
Jan 6, 2026
+80 −93

Conversation

@ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented Jan 5, 2026 •
edited
Loading

Objective

TextPipeline::update_buffer uses a trick to cache the spans buffer's capacity.
It's awkwardly implemented though, with the buffer recovery code repeated twice.

Solution

Rework the function to remove the duplication of the spans buffer recovery code.

@ickshonpe ickshonpe added A-Text Rendering and layout for characters D-Straightforward Simple bug fixes and API improvements, docs, test and examples C-Code-Quality A section of code that is hard to understand or change S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 5, 2026
@ickshonpe
TextPipeline::update_buffer uses some trick to cache its span vec's…
35281e4 
… capacity. Reworked the function to remove the duplication of the spans buffer recovery code.
@ickshonpe ickshonpe force-pushed the text-pipeline-update-buffer-spans-refactor branch from 894a3c6 to 35281e4 Compare January 5, 2026 20:31
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 6, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 6, 2026
Merged via the queue into bevyengine:main with commit 53ae507 Jan 6, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

+1 more reviewer

@kfc35 kfc35 kfc35 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Text Rendering and layout for characters C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ickshonpe @kfc35 @alice-i-cecile