Skip to content

Conversation

@ickshonpe
Copy link
Contributor

Objective

Included some naive test code for system fonts in the text example in #22156 by mistake.

Solution

Revert the changes to the example.

@ickshonpe ickshonpe added C-Examples An addition or correction to our examples A-Text Rendering and layout for characters D-Trivial Nice and easy! A great choice to get started with Bevy S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 5, 2026
.add_systems(Update, (text_update_system, text_color_system));

let mut f = app.world_mut().resource_mut::<CosmicFontSystem>();
f.db_mut().load_system_fonts();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this pr, but is there any documentation or example of loading the system fonts?

Copy link
Contributor Author

@ickshonpe ickshonpe Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No not really, the support is quite half baked atm. The changes from #22156 just make it possible to use system fonts loaded with cosmic text's font database API. I just made an issue a moment ago, #22391, about adding an official system fonts example.

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 5, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 5, 2026
@alice-i-cecile alice-i-cecile added this to the 0.18 milestone Jan 5, 2026
@ickshonpe ickshonpe modified the milestones: 0.18, 0.19 Jan 5, 2026
Merged via the queue into bevyengine:main with commit 2379278 Jan 5, 2026
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Text Rendering and layout for characters C-Examples An addition or correction to our examples D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants