Skip to content

Conversation

@GitGhillie
Copy link
Contributor

Objective

I was looking at the diff of #22207 and noticed there is a bit of code duplication.

Solution

Move the toggle functionality into a function, update the examples.

Testing

  • Tested by running the examples and toggling time.

Copy link
Contributor

@kfc35 kfc35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, I definitely approve of this! Thank you

@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it A-Time Involves time keeping and reporting labels Dec 29, 2025
@alice-i-cecile alice-i-cecile added this to the 0.19 milestone Dec 29, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 30, 2025
Merged via the queue into bevyengine:main with commit 8abfa23 Dec 30, 2025
42 checks passed
@GitGhillie GitGhillie deleted the gitghillie/time-virtual-toggle branch December 30, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Time Involves time keeping and reporting C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants