Skip to content

Fix Updated images occasionally never displayed on materials #22255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ItsDoot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Updated images occasionally never displayed on materials #22255

ItsDoot wants to merge 1 commit into from
+27 −18

Conversation

@ItsDoot
Copy link
Contributor

@ItsDoot ItsDoot commented Dec 24, 2025

Objective

Solution

Replace HashSet usage with IndexSet in DagGroups to maintain insertion order like the previous Vec implementation.

Testing

Used the provided example in the bug report. Should we add it as a test or example somewhere?

@ItsDoot ItsDoot added C-Bug An unexpected or incorrect behavior A-ECS Entities, components, systems, and events P-Regression Functionality that used to work but no longer does. Add a test for this! S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 24, 2025
@ItsDoot ItsDoot added this to the 0.18 milestone Dec 24, 2025
@mockersf
Copy link
Member

mockersf commented Dec 24, 2025

Used the provided example in the bug report. Should we add it as a test or example somewhere?

It wouldn't really be useful for users as an example, and we should avoid adding test examples as it has a negative impact on contributors.

Could we add a unit test on schedule ordering?

@andrewhickman andrewhickman mentioned this pull request Dec 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mockersf mockersf mockersf approved these changes

Assignees

No one assigned

Labels

A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior P-Regression Functionality that used to work but no longer does. Add a test for this! S-Needs-Review Needs reviewer attention (from anyone!) to move forward

Projects

None yet

Milestone

0.18

Development

Successfully merging this pull request may close these issues.

0.18 Regression: Updated images occasionally never displayed on materials

2 participants

@ItsDoot @mockersf