Make LoadContext::finish add all dependencies, and avoid a second texture load in GltfLoader.
#22227
+430
−363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andriyDev
added
A-Assets
andriyDev
force-pushed
the
gltf-one-load
branch
from
e2b68a3 to
5b5297a
Compare
ChristopherBiscardi
approved these changes
Dec 22, 2025
Contributor
ChristopherBiscardi
left a comment
ChristopherBiscardi
left a comment
There was a problem hiding this comment.
read through the code and it all seems reasonable to me. +100 on the deduplication.
… if not loaded through their load context.
…just clone texture handles.
andriyDev
force-pushed
the
gltf-one-load
branch
from
5b5297a to
a2a4e67
Compare
mockersf
reviewed
Dec 24, 2025
mockersf
reviewed
Dec 24, 2025
mockersf
approved these changes
Dec 24, 2025
andriyDev
added
S-Ready-For-Final-Review
mockersf
pushed a commit
that referenced
this pull request
Dec 30, 2025
…exture load in GltfLoader. (#22227) - The glTF loader previously did two loads for textures: the first did all the expected parsing and loading. The second would **intentionally** try to perform the same load to A) avoid doing a second load, and B) to add the handle as a dependency specifically for the material - so that the material would not be "loaded with dependencies" until all its textures were loaded. - In general, it's possible for an asset to have a handle to another asset, without that handle being considered a dependency according to the `LoadContext`. - Also, some handles in the `StandardMaterial` were missing the `#[dependency]` attribute. - Add the dependency attribute to all handles in `StandardMaterial`. - Make the gltf anisotropy extension also use the `parse_material_extension_texture` function like all the other extensions (the existing implementation matched exactly). - Made `LoadContext::finish` update the list of dependencies with `VisitDependencies`. - Propagate the list of texture handles through the `GltfLoader` and clone the handle out when necessary. - Added tests to `bevy_asset` to verify tracking dependencies works - this also fails before the rest of this PR. - Ran the `load_gltf` example and it still works. This won't show whether the dependency tracking works correctly though.
mockersf
pushed a commit
that referenced
this pull request
Dec 30, 2025
…exture load in GltfLoader. (#22227) - The glTF loader previously did two loads for textures: the first did all the expected parsing and loading. The second would **intentionally** try to perform the same load to A) avoid doing a second load, and B) to add the handle as a dependency specifically for the material - so that the material would not be "loaded with dependencies" until all its textures were loaded. - In general, it's possible for an asset to have a handle to another asset, without that handle being considered a dependency according to the `LoadContext`. - Also, some handles in the `StandardMaterial` were missing the `#[dependency]` attribute. - Add the dependency attribute to all handles in `StandardMaterial`. - Make the gltf anisotropy extension also use the `parse_material_extension_texture` function like all the other extensions (the existing implementation matched exactly). - Made `LoadContext::finish` update the list of dependencies with `VisitDependencies`. - Propagate the list of texture handles through the `GltfLoader` and clone the handle out when necessary. - Added tests to `bevy_asset` to verify tracking dependencies works - this also fails before the rest of this PR. - Ran the `load_gltf` example and it still works. This won't show whether the dependency tracking works correctly though.
mockersf
pushed a commit
that referenced
this pull request
Dec 30, 2025
…exture load in GltfLoader. (#22227) - The glTF loader previously did two loads for textures: the first did all the expected parsing and loading. The second would **intentionally** try to perform the same load to A) avoid doing a second load, and B) to add the handle as a dependency specifically for the material - so that the material would not be "loaded with dependencies" until all its textures were loaded. - In general, it's possible for an asset to have a handle to another asset, without that handle being considered a dependency according to the `LoadContext`. - Also, some handles in the `StandardMaterial` were missing the `#[dependency]` attribute. - Add the dependency attribute to all handles in `StandardMaterial`. - Make the gltf anisotropy extension also use the `parse_material_extension_texture` function like all the other extensions (the existing implementation matched exactly). - Made `LoadContext::finish` update the list of dependencies with `VisitDependencies`. - Propagate the list of texture handles through the `GltfLoader` and clone the handle out when necessary. - Added tests to `bevy_asset` to verify tracking dependencies works - this also fails before the rest of this PR. - Ran the `load_gltf` example and it still works. This won't show whether the dependency tracking works correctly though.
mockersf
pushed a commit
that referenced
this pull request
Dec 30, 2025
…exture load in GltfLoader. (#22227) - The glTF loader previously did two loads for textures: the first did all the expected parsing and loading. The second would **intentionally** try to perform the same load to A) avoid doing a second load, and B) to add the handle as a dependency specifically for the material - so that the material would not be "loaded with dependencies" until all its textures were loaded. - In general, it's possible for an asset to have a handle to another asset, without that handle being considered a dependency according to the `LoadContext`. - Also, some handles in the `StandardMaterial` were missing the `#[dependency]` attribute. - Add the dependency attribute to all handles in `StandardMaterial`. - Make the gltf anisotropy extension also use the `parse_material_extension_texture` function like all the other extensions (the existing implementation matched exactly). - Made `LoadContext::finish` update the list of dependencies with `VisitDependencies`. - Propagate the list of texture handles through the `GltfLoader` and clone the handle out when necessary. - Added tests to `bevy_asset` to verify tracking dependencies works - this also fails before the rest of this PR. - Ran the `load_gltf` example and it still works. This won't show whether the dependency tracking works correctly though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
LoadContext.StandardMaterialwere missing the#[dependency]attribute.Solution
StandardMaterial.parse_material_extension_texturefunction like all the other extensions (the existing implementation matched exactly).LoadContext::finishupdate the list of dependencies withVisitDependencies.GltfLoaderand clone the handle out when necessary.Testing
bevy_assetto verify tracking dependencies works - this also fails before the rest of this PR.load_gltfexample and it still works. This won't show whether the dependency tracking works correctly though.