Change feather's radio control's visibility from visible to inherited #21789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
alice-i-cecile
approved these changes
Nov 9, 2025
alice-i-cecile
added
C-Bug
alice-i-cecile
added
D-Straightforward
viridia
approved these changes
Nov 9, 2025
alice-i-cecile
added
S-Ready-For-Final-Review
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 16, 2025
…21847) # Objective Seems the checkbox part is missing in PR #21789. Make the checkbox marker invisible when the whole widget is `Visibility::Hidden`. ## Solution Change the maker's visibility to `Inherited` rather than `Visible`. ## Testing Manually added `Visibility::Hidden` to the root node of `examples/ui/feathers.rs`, and verified nothing is visible.
beicause
pushed a commit
to beicause/bevy
that referenced
this pull request
Nov 26, 2025
…evyengine#21847) # Objective Seems the checkbox part is missing in PR bevyengine#21789. Make the checkbox marker invisible when the whole widget is `Visibility::Hidden`. ## Solution Change the maker's visibility to `Inherited` rather than `Visible`. ## Testing Manually added `Visibility::Hidden` to the root node of `examples/ui/feathers.rs`, and verified nothing is visible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Setting a feather radio button's visibility to
Visibility::Hidden(bottom row of the below image) should hide the radio button entirely. Instead, the mark stays visible.My use case for this is a settings panel, in which the radio buttons are in a collapsible section that makes them hidden.
Solution
Changing the visibility of the mark from
Visibility::VisibletoVisibility::Inheritedappears to me to be the cleanest solution, as it does minimal work and has no downsides.I considered adding a system to my project that would override the visibility each time, but the mark's marker component is not exported.
I also considered adding a system to my project which removed the
Checkedcomponent from the radio button when making it hidden, and re-adds it when making it visible.Testing
I tested this change by editing the source file in
~/.cargo/registry/, runningcargo clean, then doing a full rebuild of my app, and it worked as expected.Showcase