Skip to content

ci: lint the frontend and workflows on pull requests #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DerekRoberts merged 2 commits into from
Oct 11, 2026
Merged

ci: lint the frontend and workflows on pull requests #667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
203f6cc
ci: lint the frontend and workflows on pull requests
DerekRoberts Oct 9, 2026
9a2a5b4
Merge branch 'main' into ci/lint-frontend-and-workflows
DerekRoberts Oct 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/actionlint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
self-hosted-runner:
# GitHub-hosted runner labels newer than actionlint's built-in list
labels:
- ubuntu-26.04
4 changes: 2 additions & 2 deletions .github/workflows/.deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ on:
autoscaling:
description: Autoscaling enabled or not for the deployments
required: false
type: string
default: "true"
type: boolean
default: true
environment:
description: Environment name; omit for PRs
required: false
Expand Down
32 changes: 31 additions & 1 deletion .github/workflows/analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,11 +93,41 @@ jobs:
- run: npm ci
- run: npm test

frontend-lint:
name: Frontend Lint
runs-on: ubuntu-26.04
timeout-minutes: 10
permissions:
contents: read
defaults:
run:
working-directory: frontend
steps:
- uses: actions/checkout@v7
- uses: actions/setup-node@v7
with:
node-version: "24.x"
- run: npm ci
- run: npm run lint

# Catches broken workflows on the PR, including those that only run after merge or on a schedule
workflow-lint:
name: Workflow Lint
runs-on: ubuntu-26.04
timeout-minutes: 5
permissions:
contents: read
steps:
- uses: actions/checkout@v7
- uses: docker://rhysd/actionlint:1.7.12@sha256:b1934ee5f1c509618f2508e6eb47ee0d3520686341fec936f3b79331f9315667
with:
args: -color

# This job is the merge gate for this workflow. Every job in this
# workflow must be listed in 'needs', or its failure won't block the PR.
results:
name: Analysis Results
needs: [trivy, api-tests, unit-tests]
needs: [trivy, api-tests, unit-tests, frontend-lint, workflow-lint]
if: always()
runs-on: ubuntu-26.04
timeout-minutes: 1
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/scheduled.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
oc project ${{ vars.OC_NAMESPACE }}

# Get API key
API_KEY=$(oc get secrets/pubcode --template={{.data.API_KEY}} | base64 -d)
API_KEY=$(oc get secrets/pubcode --template='{{.data.API_KEY}}' | base64 -d)
API_URL=https://$(oc get ingress/pubcode-api --template='{{(index .spec.rules 0).host}}')
API_KEY="${API_KEY}" API_URL="${API_URL}" node src/main.js

Expand Down Expand Up @@ -153,7 +153,7 @@ jobs:
oc project ${{ vars.OC_NAMESPACE }}

# Get API key
API_KEY=$(oc get secrets/pubcode --template={{.data.API_KEY}} | base64 -d)
API_KEY=$(oc get secrets/pubcode --template='{{.data.API_KEY}}' | base64 -d)
API_URL=https://$(oc get ingress/pubcode-api --template='{{(index .spec.rules 0).host}}')
API_KEY="${API_KEY}" API_URL="${API_URL}" node index.js

Expand Down
Loading