Repository navigation
ci: lint the frontend and workflows on pull requests - #667
Merged
Merged
Conversation
Frontend lint never ran in CI, and nothing checked workflows that only run after merge or on a schedule, so Renovate could auto-merge a broken one. Both now run in analysis.yml and feed Analysis Results. The fixes actionlint asked for are included: the deploy workflow's autoscaling input is a boolean, and the oc templates in scheduled.yml are quoted. Refs #597
There was a problem hiding this comment.
🟢 Approval recommended
The lint gates are correctly integrated, and the supporting workflow fixes preserve existing behavior.
0 open findings
What changed in this PR
Adds required frontend and workflow linting to prevent invalid changes from merging.
Changes:
- Adds frontend ESLint and actionlint merge gates.
- Configures actionlint for the
ubuntu-26.04runner. - Corrects reusable workflow input typing and shell quoting.
| File | Description |
|---|---|
.github/workflows/analysis.yml |
Adds lint jobs to the analysis merge gate. |
.github/workflows/.deploy.yml |
Changes autoscaling to a boolean input. |
.github/workflows/scheduled.yml |
Quotes OpenShift template expressions. |
.github/actionlint.yaml |
Registers the newer runner label. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No required check lints the frontend or the workflows, so Renovate can auto-merge a frontend dependency that breaks lint, or a workflow update that only breaks after merge (merge, close and scheduled workflows don't run on the PR).
Refs #597
Changes
analysis.ymljobs, both listed inAnalysis Resultsneedsso they gate merges:Frontend Lint: runsnpm run lintinfrontend/.Workflow Lint: runs actionlint 1.7.12 (digest-pinned image) over every workflow, with its built-in shellcheck..github/actionlint.yaml: declares theubuntu-26.04runner label, which is newer than actionlint's built-in list..deploy.yml'sautoscalinginput was typedstring, but every caller passes a boolean. It's now a boolean with defaulttrue. Helm receives the same value.scheduled.yml: theoc get secrets/pubcode --template={{.data.API_KEY}}braces are quoted (shellcheck SC1083).ocgets the same argument.Both lints pass locally on this branch.
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: