ci: gate PRs on per-workflow results checks and run unit tests

[DerekRoberts]

Renovate PRs can auto-merge without any tests running for the crawler, the API, the schema script or the soft-delete utility. The required checks only build images and run the Cypress UI tests.

Changes

• Results checks, one per PR workflow (same pattern as quickstart-openshift). Each needs every job in its workflow, runs with if: always(), and fails if any of those jobs failed or was cancelled:
  • pr-open.yml: Results is renamed PR Results.
  • analysis.yml: new Analysis Results.
  • pr-validate.yml: its only job is renamed Validate Results.
• No path filters. Test jobs have no if: and always run. The only legitimate skips are:
  • Trivy on draft PRs.
  • Jobs downstream of a failed job, and that failure already fails Results.
• API tests (api/test): the Express app against a MongoDB service, using the same image as database/Dockerfile. They cover:
  • API-key checks on bulk-load and delete.
  • Request validation.
  • Bulk-load insert, replace and invalid-entry skip.
  • The flattened list.
  • Soft delete hiding an entry, and a later bulk-load restoring it.
• Crawler tests: YAML-to-entry mapping, including the legacy version field; skipping archived repos and repos with no default branch; the one-day update window; and the .yaml fallback.
• Schema script tests: reading ministry names from the page HTML and from the published schema, and updating the enum only when the lists differ.
• Utility tests move from pr-open.yml to the analysis matrix.
• Refactor for testability: crawler/src/main.js and schema/script/index.js now export their logic and only run when executed directly. Scheduled job behaviour is unchanged.

After merge

To make these the merge gates, the branch rulesets need to require PR Results, Analysis Results and Validate Results. That's a settings change, not part of this PR.

Refs #597

---

Thanks for the PR!

Deployments, as required, will be available below:

• Frontend
• API

Please create PRs in draft mode. Mark as ready to enable:

• Analysis Workflow

After merge, new images are deployed in:

• Merge Workflow

[Copilot]

🟢 Approval recommended

The workflow gates include all relevant jobs, and the refactors preserve scheduled behavior while adding meaningful coverage.

0 open findings

What changed in this PR

Adds comprehensive backend/unit testing and reliable per-workflow merge gates.

Changes:

• Adds API, crawler, schema, and utility tests to the analysis workflow.
• Introduces aggregate result checks for PR workflows.
• Refactors crawler and schema logic for isolated testing.

File	Description
.github/​workflows/​analysis.yml	Runs test suites and adds the analysis gate.
.github/​workflows/​pr-open.yml	Renames and strengthens the PR gate.
.github/​workflows/​pr-validate.yml	Renames the validation check.
AGENTS.md	Documents tests and merge gates.
api/​package.json	Adds the API test command.
api/​test/​pub-code-api.test.js	Adds MongoDB-backed API integration tests.
crawler/​package.json	Adds the crawler test command.
crawler/​src/​main.js	Extracts testable crawler functions.
crawler/​test/​main.test.js	Tests mapping, filtering, dates, and fallback behavior.
schema/​script/​index.js	Extracts testable schema-update functions.
schema/​script/​package.json	Adds the schema test command.
schema/​script/​test/​index.test.js	Tests ministry parsing and updates.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[mishraomp]

more tests , yay 🥳