fix(api): answer bulk load only after saving

[DerekRoberts]

POST /api/pub-code/bulk-load started the database writes and sent 200 straight away. If saving failed, the crawler still saw success, so the scheduled crawl went green even when nothing was stored.

Changes

• bulkLoad now waits for insertOrUpdate and answers 200 only after the entries are saved.

• A save failure goes to the handler's existing catch: it's logged, emailed when EMAIL_RECIPIENTS is set, and answered with 500 { message: "Internal server error" }. The crawler already exits 1 on an error response, so a failed load now fails the scheduled run.

• The sendEmailForError helper was only used by the old fire-and-forget path, so it's removed.

• New tests in api/test/bulk-load.test.js:

  • a failed save answers 500;
  • 200 is sent only after a slow save finishes.

  Both fail on the old code.

Tests and CI

The new tests need no database. They run in CI's API Tests job (added in #658, now on main). All 8 API tests pass there, including #658's MongoDB integration tests, which poll for the save and so work with or without this change.

Because the response now waits for the save, a very large payload could take longer to answer. Sequential saves of a few hundred entries should finish well within the route timeout.

---

Thanks for the PR!

Deployments, as required, will be available below:

• Frontend
• API

Please create PRs in draft mode. Mark as ready to enable:

• Analysis Workflow

After merge, new images are deployed in:

• Merge Workflow

[Copilot]

🟢 Approval recommended

The implementation correctly propagates persistence failures and the focused tests cover the regression.

0 open findings

What changed in this PR

Ensures bulk-load requests report success only after database persistence completes.

Changes:

• Awaits bulk insert/update operations and routes failures through existing error handling.
• Removes obsolete fire-and-forget error-email helper.
• Adds tests for save failures and delayed saves.

File	Description
api/​src/​services/​pub-code-service.js	Awaits persistence before responding.
api/​test/​bulk-load.test.js	Verifies failure and response-order behavior.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.