Skip to content

agents(starlark): require is_ prefix for config_setting names #4258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rickeylev merged 1 commit into from
Oct 13, 2026
Merged

agents(starlark): require is_ prefix for config_setting names #4258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .agents/rules/starlark.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ globs: "*.bzl,BUILD,BUILD.bazel,*.bazel"
`@bazel_skylib//lib:types.bzl` instead of `type(x)` comparisons.
* **Non-Info Provider Naming**: Add `# buildifier: disable=name-conventions`
above `provider()` declarations that do not end in `Info` (e.g. `*Fileset`).
* **`config_setting` Naming**: Prefix `config_setting` names with `is_` (e.g.
`is_linux_x86_64`), so that `select()` keys read as conditions.
* **Docstring Formatting Invariants**: Use triple-quoted strings for multi-line
docstrings without trailing backslashes (`\`) for line continuation.
* **No Bazel Copyright Headers**: Do not add Bazel copyright headers to new or
Expand Down
1 change: 1 addition & 0 deletions .agents/skills/review-code/review-starlark-prompt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,6 @@ in `git diff` against the project's Starlark coding rules and conventions:
`python/private/common_labels.bzl` rather than redefining `Label("//...")`.
8. Prefer `types.is_*` helpers from `@bazel_skylib//lib:types.bzl` over
`type(x)` comparisons.
9. Verify `config_setting` names start with `is_` (or `_is_` when private).

@.agents/skills/review-code/review-report-format.md
Loading