Repository navigation
agents(starlark): require is_ prefix for config_setting names - #4258
Merged
rickeylev merged 1 commit intoOct 13, 2026
Merged
Conversation
Prefixing `config_setting` target names with `is_` makes `select()` keys read naturally as conditions and matches existing repository conventions. Document the `is_` prefix convention for `config_setting` targets in `.agents/rules/starlark.md` and add a check to the Starlark review auditor prompt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefixing
config_settingtarget names withis_makesselect()keys read naturally as conditions and matches existing repository
conventions.
Document the
is_prefix convention forconfig_settingtargets in.agents/rules/starlark.mdand add a check to the Starlark reviewauditor prompt.