Skip to content

feat: add sdk name/version to user agent header #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nvasiu merged 1 commit into from
Apr 15, 2026
Merged

feat: add sdk name/version to user agent header #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/aws_durable_execution_sdk_python/lambda_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import boto3
from botocore.config import Config

from aws_durable_execution_sdk_python.__about__ import __version__
from aws_durable_execution_sdk_python.exceptions import (
CallableRuntimeError,
CheckpointError,
Expand Down Expand Up @@ -1059,6 +1060,7 @@ def initialize_client(cls) -> LambdaClient:
config=Config(
connect_timeout=5,
read_timeout=50,
user_agent_extra=f"@aws/durable-execution-sdk-python/{__version__}",
Copy link
Copy Markdown
Contributor

@yaythomas yaythomas Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, strictly speaking the package name is aws-durable-execution-sdk-python

java's maven package is:

aws-durable-execution-sdk-java

but it uses "@aws/durable-execution-sdk-java/" for user agent str.

ts/js npm package is:

@aws/durable-execution-sdk-js

it uses the same for user agent str.

Copy link
Copy Markdown
Contributor

@yaythomas yaythomas Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, might as well standardize on @aws/durable-execution-sdk-python

),
)
return cls(client=cls._cached_boto_client)
Expand Down
5 changes: 5 additions & 0 deletions tests/lambda_service_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

import pytest

from aws_durable_execution_sdk_python.__about__ import __version__
from aws_durable_execution_sdk_python.exceptions import (
CallableRuntimeError,
CheckpointError,
Expand Down Expand Up @@ -1940,6 +1941,7 @@ def test_lambda_client_initialize_client_default(
config = call_args[1]["config"]
assert config.connect_timeout == 5
assert config.read_timeout == 50
assert config.user_agent_extra == f"@aws/durable-execution-sdk-python/{__version__}"
assert isinstance(client, LambdaClient)


Expand All @@ -1963,6 +1965,7 @@ def test_lambda_client_initialize_client_with_endpoint(
config = call_args[1]["config"]
assert config.connect_timeout == 5
assert config.read_timeout == 50
assert config.user_agent_extra == f"@aws/durable-execution-sdk-python/{__version__}"
assert isinstance(client, LambdaClient)


Expand Down Expand Up @@ -2038,6 +2041,8 @@ def test_lambda_client_initialize_client_no_endpoint(
call_args = mock_boto_client.call_args
assert call_args[0] == ("lambda",)
assert "config" in call_args[1]
config = call_args[1]["config"]
assert config.user_agent_extra == f"@aws/durable-execution-sdk-python/{__version__}"
assert isinstance(client, LambdaClient)


Expand Down
Loading