Open
Conversation
yaythomas
requested changes
Apr 15, 2026
| config=Config( | ||
| connect_timeout=5, | ||
| read_timeout=50, | ||
| user_agent_extra=f"aws-durable-execution-sdk-python/{__version__}", |
Contributor
There was a problem hiding this comment.
both java and ts follow something like
@aws/durable-execution-sdk-java/1.2.3
nvasiu
force-pushed
the
add-user-agent-header
branch
from
592facc to
0f5e32a
Compare
yaythomas
reviewed
Apr 15, 2026
| config=Config( | ||
| connect_timeout=5, | ||
| read_timeout=50, | ||
| user_agent_extra=f"@aws/durable-execution-sdk-python/{__version__}", |
Contributor
There was a problem hiding this comment.
hmm, strictly speaking the package name is aws-durable-execution-sdk-python
java's maven package is:
aws-durable-execution-sdk-java
but it uses "@aws/durable-execution-sdk-java/" for user agent str.
ts/js npm package is:
@aws/durable-execution-sdk-js
it uses the same for user agent str.
Contributor
There was a problem hiding this comment.
yes, might as well standardize on @aws/durable-execution-sdk-python
yaythomas
approved these changes
Apr 15, 2026
yaythomas
requested changes
Apr 15, 2026
Contributor
yaythomas
left a comment
yaythomas
left a comment
There was a problem hiding this comment.
please update commit to follow commit rules from contributing.md
- Add user_agent_extra field to the default Lambda client config, which appends the SDK name and version to the user agent header - Update tests to verify the new user_agent_extra field Include SDK name and version in the Lambda client's user agent header to provide better visibility for debugging.
nvasiu
force-pushed
the
add-user-agent-header
branch
from
0f5e32a to
0dc9706
Compare
nvasiu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#300
Description of changes:
user_agent_extrafield to the default LambdaClient config, to pass the SDK name/version into UserAgent headers.user_agent_extrais appended to the existing UserAgent header value (reference).user_agent_extra.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.