fix(dev): use TUI picker for harness deploy when launching dev from interactive menu#1410
Open
jesseturner21 wants to merge 2 commits into
Open
fix(dev): use TUI picker for harness deploy when launching dev from interactive menu#1410jesseturner21 wants to merge 2 commits into
jesseturner21 wants to merge 2 commits into
Conversation
…nteractive menu When selecting "dev" from the interactive `agentcore` menu with preview enabled, harness deploy was rendered inline via runCliDeploy() instead of using the full-screen TUI (DevScreen) that `agentcore dev` uses directly. Now launchBrowserDev() uses launchTuiDevScreenWithPicker() — the same alt-screen TUI picker used by the direct `agentcore dev` command — when preview is enabled and harnesses are present, so deploy progress renders identically regardless of entry path. Closes #1376 Constraint: Must be gated behind isPreviewEnabled() to match GA behavior Rejected: Adding ENTER_ALT_SCREEN around runCliDeploy | would still show spinner-based output instead of the structured DevScreen TUI Confidence: high Scope-risk: narrow
github-actions
Bot
added
size/m
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
github-actions
Bot
removed
the
agentcore-harness-reviewing
Contributor
Package TarballHow to installgh release download pr-1410-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.15.0.tgz |
Contributor
Coverage Report
|
Remove duplicated OTEL/runBrowserMode code by using pickerResult with optional chaining in the shared path. Trim test file to only the two meaningful cases: picker used for deploy, and user back-out handled.
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agentcoremenu rendered harness deploy inline (text spinners viarunCliDeploy), whileagentcore devused the full-screen TUI (DevScreen) with structured deploy progresslaunchBrowserDev()now useslaunchTuiDevScreenWithPicker()— the same alt-screen TUI picker used by the directagentcore devcommand — whenisPreviewEnabled()and harnesses are presentCloses #1376
Test plan
launchBrowserDevverifying TUI picker is used when preview enabled + harnesses presentrunCliDeployis NOT called (deploy handled by DevScreen TUI instead)agentcore create→cdinto project →agentcore→ select "dev" → verify deploy uses full-screen TUIagentcore dev→ verify same full-screen TUI deploy experience