fix(policy): document the executable normalization wrapper - #100
Conversation
|
Independent review: PASS at efa07c0. A reviewer who did not write the change ran all 44 policy CLI tests. In a disposable copy, restoring the original documented command made both new tests fail. The valid case asserts the normalized event fields; the negative cases assert identity-mismatch and malformed-receipt rejection. No actionable correctness or comment findings. Both installed-parent sessions also passed on the exact candidate. An independent audit compared all 213 packaged file hashes and reread the saved JSON, diagnostics, and exit codes from both sessions. The preserved real receipt normalized to |
|
Copilot could not review this candidate because the requester has reached its review quota. The submitted review records that limit; there are no inline comments, pending owner replies, or unresolved threads. This is unavailable review coverage, not Copilot approval. Independent review, both installed-parent checks, local checks, and GitHub CI passed at efa07c0. |
Closes #99
What changed
The documented receipt-normalization command ran an import-only module, exited successfully, and produced no policy event, even for invalid input. Point it at the shipped
pstack-model-policyexecutable. Tests extract that command from the reference and verify its event fields, identity-mismatch rejection, and malformed-input rejection. Package version is 1.10.1.Verification
pstack:poteto-mode, read its provider-dispatch reference, and executed the documented command.Candidate
efa07c0beefe37c9f9fd254b704a074ee3d593f7, version 1.10.1. In each parent, a preserved real Claude receipt produced exit 0 and a 970-byte JSON event with the assigned descriptor andcompletestatus. A synthetic copy with a wrong model produced exit 65, empty stdout, and a model identity-mismatch diagnostic. These are receipt replays, not fresh provider executions. Both sessions independently reread and asserted the saved outputs. Personal plugin installations and model sheets were unchanged.Before the fix, the documented command returned exit 0 with empty stdout and stderr for both receipts. An independent reviewer passed the CLI suite and confirmed that both new tests fail with the old documentation in a disposable copy. No actionable findings. Evidence is retained in the maintainer's
open-pstack-issue99-evidencedirectory, including candidate hashes, parent transcripts, command captures, and independent review.Documentation impact
Updated the owning
provider-dispatch.mdinvocation and added a reproducible receipt-normalization recipe to.agents/skills/verify-open-pstack/features/routing.md.