Skip to content

Use staticmethod for get_type_from_code #4693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svartkanin merged 1 commit into from
Aug 3, 2026
+4 −4
Merged

Use staticmethod for get_type_from_code #4693

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions archinstall/lib/models/device.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -753,13 +753,13 @@ class PartitionType(StrEnum):
PRIMARY = auto()
_UNKNOWN = 'unknown'

@classmethod
def get_type_from_code(cls, code: int) -> Self:
@staticmethod
def get_type_from_code(code: int) -> PartitionType:
if code == parted.PARTITION_NORMAL:
return cls.PRIMARY
return PartitionType.PRIMARY
else:
debug(f'Partition code not supported: {code}')
return cls._UNKNOWN
return PartitionType._UNKNOWN

def get_partition_code(self) -> int | None:
if self == PartitionType.PRIMARY:
Expand Down