Use staticmethod for get_type_from_code - #4693
Merged
Merged
Conversation
Addresses the following:
pyright
```
archinstall/lib/models/device.py:759:11 - error: Type "Literal[PartitionType.PRIMARY]" is not assignable to return type "Self@PartitionType"
Type "Literal[PartitionType.PRIMARY]" is not assignable to type "Self@PartitionType" (reportReturnType)
archinstall/lib/models/device.py:762:11 - error: Type "Literal[PartitionType._UNKNOWN]" is not assignable to return type "Self@PartitionType"
Type "Literal[PartitionType._UNKNOWN]" is not assignable to type "Self@PartitionType" (reportReturnType)
```
pyrefly
```
ERROR Returned type `Literal[PartitionType.PRIMARY]` is not assignable to declared return type `Self@PartitionType` [bad-return]
--> archinstall/lib/models/device.py:759:11
|
757 | def get_type_from_code(cls, code: int) -> Self:
| ---- declared return type
758 | if code == parted.PARTITION_NORMAL:
759 | return cls.PRIMARY
| ^^^^^^^^^^^
|
ERROR Returned type `Literal[PartitionType._UNKNOWN]` is not assignable to declared return type `Self@PartitionType` [bad-return]
--> archinstall/lib/models/device.py:762:11
|
757 | def get_type_from_code(cls, code: int) -> Self:
| ---- declared return type
758 | if code == parted.PARTITION_NORMAL:
759 | return cls.PRIMARY
760 | else:
761 | debug(f'Partition code not supported: {code}')
762 | return cls._UNKNOWN
| ^^^^^^^^^^^^
|
```
ty
```
error[invalid-return-type]: Return type does not match returned value
--> archinstall/lib/models/device.py:757:44
|
757 | def get_type_from_code(cls, code: int) -> Self:
| ---- Expected `Self@get_type_from_code` because of return type
758 | if code == parted.PARTITION_NORMAL:
759 | return cls.PRIMARY
| ^^^^^^^^^^^ expected `Self@get_type_from_code`, found `Literal[PartitionType.PRIMARY]`
|
error[invalid-return-type]: Return type does not match returned value
--> archinstall/lib/models/device.py:757:44
|
757 | def get_type_from_code(cls, code: int) -> Self:
| ---- Expected `Self@get_type_from_code` because of return type
758 | if code == parted.PARTITION_NORMAL:
759 | return cls.PRIMARY
760 | else:
761 | debug(f'Partition code not supported: {code}')
762 | return cls._UNKNOWN
| ^^^^^^^^^^^^ expected `Self@get_type_from_code`, found `Literal[PartitionType._UNKNOWN]`
|
```
svartkanin
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the following:
pyright
pyrefly
ty