Skip to content

perf: offload BeautifulSoup parsing to a thread via asyncio.to_thread #1817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vdusek merged 1 commit into from
Mar 29, 2026
+4 −2
Merged

perf: offload BeautifulSoup parsing to a thread via asyncio.to_thread #1817

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/crawlee/crawlers/_beautifulsoup/_beautifulsoup_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from __future__ import annotations

import asyncio
from typing import TYPE_CHECKING, Literal

from bs4 import BeautifulSoup, Tag
Expand All @@ -23,11 +24,12 @@ def __init__(self, parser: BeautifulSoupParserType = 'lxml') -> None:

@override
async def parse(self, response: HttpResponse) -> BeautifulSoup:
return BeautifulSoup(await response.read(), features=self._parser)
body = await response.read()
return await asyncio.to_thread(BeautifulSoup, body, features=self._parser)

@override
async def parse_text(self, text: str) -> BeautifulSoup:
return BeautifulSoup(text, features=self._parser)
return await asyncio.to_thread(BeautifulSoup, text, features=self._parser)

@override
def is_matching_selector(self, parsed_content: Tag, selector: str) -> bool:
Expand Down
Loading