perf: offload BeautifulSoup parsing to a thread via asyncio.to_thread#1817
Open
perf: offload BeautifulSoup parsing to a thread via asyncio.to_thread#1817
asyncio.to_thread#1817Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
asyncio.to_thread
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1817 +/- ##
==========================================
- Coverage 92.23% 92.23% -0.01%
==========================================
Files 157 157
Lines 10863 10884 +21
==========================================
+ Hits 10020 10039 +19
- Misses 843 845 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BeautifulSoup()constructor performs synchronous HTML parsing that blocks the event loop, degrading concurrency.parse()andparse_text()inasyncio.to_thread()to offload parsing to a worker thread, consistent with howParselParser.parse()already works.Test plan
🤖 Generated with Claude Code