Skip to content

docs: Remove conda special instructions for brotli #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pijukatel merged 1 commit into from
Jul 22, 2026
+2 −14
Merged

docs: Remove conda special instructions for brotli #959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions docs/01_introduction/index.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,17 +56,11 @@ For better request-body compression, opt in to `brotli`, which compresses better
</TabItem>
<TabItem value="conda-forge" label="conda-forge">
```bash
conda install conda-forge::apify-client conda-forge::brotli-python
conda install conda-forge::apify-client
```
</TabItem>
</Tabs>

:::note Extras on conda-forge

Conda doesn't support optional extras. On conda-forge, install the `brotli-python` package directly alongside the client. It provides the same `brotli` module as the PyPI extra.

@vdusek vdusek Jul 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, conda doesn't support brotli, that's true, right? So maybe we should just update this note to reflect the current state (brotli is part of the core package if I am not mistaken).

@Pijukatel Pijukatel Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it is an unnecessary detail. In conda-forge everything is commonly included (in other packages as well), it is common practice since extras are not supported yet. So I think that conda-forge users are expecting this by default.


:::

For details, see [HTTP compression](../02_concepts/13_http_compression.mdx).

## Quick example
Expand Down
8 changes: 1 addition & 7 deletions website/versioned_docs/version-3.1/01_introduction/index.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,17 +56,11 @@ For better request-body compression, opt in to `brotli`, which compresses better
</TabItem>
<TabItem value="conda-forge" label="conda-forge">
```bash
conda install conda-forge::apify-client conda-forge::brotli-python
conda install conda-forge::apify-client
```
</TabItem>
</Tabs>

:::note Extras on conda-forge

Conda doesn't support optional extras. On conda-forge, install the `brotli-python` package directly alongside the client. It provides the same `brotli` module as the PyPI extra.

:::

For details, see [HTTP compression](../02_concepts/13_http_compression.mdx).

## Quick example
Expand Down
Loading