docs: Remove conda special instructions for brotli#959
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #959 +/- ##
=======================================
Coverage 94.64% 94.64%
=======================================
Files 58 58
Lines 5263 5263
=======================================
Hits 4981 4981
Misses 282 282
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
|
||
| :::note Extras on conda-forge | ||
|
|
||
| Conda doesn't support optional extras. On conda-forge, install the `brotli-python` package directly alongside the client. It provides the same `brotli` module as the PyPI extra. |
There was a problem hiding this comment.
Well, conda doesn't support brotli, that's true, right? So maybe we should just update this note to reflect the current state (brotli is part of the core package if I am not mistaken).
There was a problem hiding this comment.
I think that it is an unnecessary detail. In conda-forge everything is commonly included (in other packages as well), it is common practice since extras are not supported yet. So I think that conda-forge users are expecting this by default.
It is now included by default: https://github.com/conda-forge/apify-client-feedstock/pull/4/changes