Skip to content

docs: Remove conda special instructions for brotli#959

Open
Pijukatel wants to merge 1 commit into
masterfrom
remove-brotli-conda-instructions
Open

docs: Remove conda special instructions for brotli#959
Pijukatel wants to merge 1 commit into
masterfrom
remove-brotli-conda-instructions

Conversation

@Pijukatel

Copy link
Copy Markdown
Contributor

@Pijukatel
Pijukatel requested a review from szaganek as a code owner July 20, 2026 08:38
@github-actions github-actions Bot added this to the 145th sprint - Tooling team milestone Jul 20, 2026
@github-actions github-actions Bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Jul 20, 2026
@Pijukatel
Pijukatel requested a review from vdusek July 20, 2026 08:38
@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.64%. Comparing base (2adf515) to head (6b8373f).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #959   +/-   ##
=======================================
  Coverage   94.64%   94.64%           
=======================================
  Files          58       58           
  Lines        5263     5263           
=======================================
  Hits         4981     4981           
  Misses        282      282           
Flag Coverage Δ
integration 92.49% <ø> (+0.18%) ⬆️
unit 83.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Pijukatel Pijukatel added the adhoc Ad-hoc unplanned task added during the sprint. label Jul 20, 2026

:::note Extras on conda-forge

Conda doesn't support optional extras. On conda-forge, install the `brotli-python` package directly alongside the client. It provides the same `brotli` module as the PyPI extra.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, conda doesn't support brotli, that's true, right? So maybe we should just update this note to reflect the current state (brotli is part of the core package if I am not mistaken).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it is an unnecessary detail. In conda-forge everything is commonly included (in other packages as well), it is common practice since extras are not supported yet. So I think that conda-forge users are expecting this by default.

@Pijukatel
Pijukatel requested a review from vdusek July 20, 2026 12:56

@vdusek vdusek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants