Skip to content

[WICKET-7179] add support for jQuery 4.0.0 #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reiern70 wants to merge 1 commit into
base: master
Choose a base branch
from
+9,689 −0
Open

[WICKET-7179] add support for jQuery 4.0.0 #1412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions wicket-core/src/main/java/org/apache/wicket/resource/JQueryResourceReference.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,21 @@ public class JQueryResourceReference extends JavaScriptResourceReference
* <strong>Note</strong>: Might not work with old jQuery plugins!
*/
public static final String VERSION_3 = "jquery/jquery-3.7.1.js";
public static final String VERSION_4 = "jquery/jquery-4.0.0.js";

public static final JQueryResourceReference INSTANCE_3 = new JQueryResourceReference(VERSION_3);
public static final JQueryResourceReference INSTANCE_4 = new JQueryResourceReference(VERSION_4);

public static JQueryResourceReference getV3()
{
return INSTANCE_3;
}

public static JQueryResourceReference getV4()
Copy link
Copy Markdown
Member

@martin-g martin-g Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have checked the diff before my comment!
The V4 is not in use yet! This is the reason why the tests pass.

Copy link
Copy Markdown
Contributor Author

@reiern70 reiern70 Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See

https://blog.jqueryui.com/2026/01/jquery-ui-1-14-2-released/

The new release seems to be compatible with 4.0

Copy link
Copy Markdown
Member

@martin-g martin-g Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link is relevant to wicket-jquery-ui and wiquery but it does not affect wicket-core anyhow.

{
return INSTANCE_4;
}

protected JQueryResourceReference(final String version)
{
super(JQueryResourceReference.class, version);
Expand Down
Loading