Skip to content

[WICKET-7179] add support for jQuery 4.0.0#1412

Open
reiern70 wants to merge 1 commit intomasterfrom
reiern70/WICKET-7179
Open

[WICKET-7179] add support for jQuery 4.0.0#1412
reiern70 wants to merge 1 commit intomasterfrom
reiern70/WICKET-7179

Conversation

@reiern70
Copy link
Copy Markdown
Contributor

@reiern70 reiern70 commented Mar 31, 2026

No description provided.

@reiern70 reiern70 requested a review from martin-g March 31, 2026 19:59
@martin-g
Copy link
Copy Markdown
Member

martin-g commented Mar 31, 2026 •
edited
Loading

I can't believe that there is no need of any migrations in wicket-jquery-ajax.js !
The migration guide is rather long - https://jquery.com/upgrade-guide/4.0/. I'd expect something to break but the JS tests pass!

@reiern70 You may want to add jquery-migrate-4.0.2.js next to jquery.js and see whether it reports something.
I think it would be a good idea to contribute it together with jquery.js until Wicket 11.0.0 is about to be released.

martin-g
martin-g reviewed Mar 31, 2026
View reviewed changes
wicket-core/src/main/java/org/apache/wicket/resource/JQueryResourceReference.java
return INSTANCE_3;
}

public static JQueryResourceReference getV4()
Copy link
Copy Markdown
Member

@martin-g martin-g Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have checked the diff before my comment!
The V4 is not in use yet! This is the reason why the tests pass.

Copy link
Copy Markdown
Contributor Author

@reiern70 reiern70 Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See

https://blog.jqueryui.com/2026/01/jquery-ui-1-14-2-released/

The new release seems to be compatible with 4.0

Copy link
Copy Markdown
Member

@martin-g martin-g Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link is relevant to wicket-jquery-ui and wiquery but it does not affect wicket-core anyhow.

@reiern70
Copy link
Copy Markdown
Contributor Author

reiern70 commented Apr 1, 2026

I will enable it and see what fails

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martin-g martin-g martin-g left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reiern70 @martin-g