TIKA-4606: Upgrade Apache Ignite from 2.x to 3.x#2648
Open
nddipiazza wants to merge 1 commit intomainfrom
Open
TIKA-4606: Upgrade Apache Ignite from 2.x to 3.x#2648nddipiazza wants to merge 1 commit intomainfrom
nddipiazza wants to merge 1 commit intomainfrom
Conversation
- Upgraded ignite-core 2.16.0 to ignite-runner 3.1.0 - Migrated configuration from IgniteConfiguration API to HOCON-based config files - Updated API usage from IgniteCache to new KeyValueView API - Fixed ExtensionConfigDTO to use Ignite 3.x Mapper annotations - Simplified IgniteStoreServer to synchronous embedded mode - Fixed EmitHandler: added null check for NO_EMIT scenario to prevent NPE - Updated gRPC proto: added emitter_id field to FetchAndParseRequest - Updated TikaGrpcServerImpl: proper lifecycle management for IgniteStoreServer - Added JVM --add-opens flags for Java 17+ compatibility - Updated unit tests (IgniteConfigStoreTest) for Ignite 3.x embedded server pattern Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades Apache Ignite from 2.16.0 to 3.1.0 in the
tika-pipes-config-store-ignitemodule and updates dependent gRPC server code.Changes
tika-pipes-config-store-ignite: Upgradedignite-core→ignite-runner 3.1.0; migrated fromIgniteConfigurationAPI to HOCON-based config; replacedIgniteCachewithKeyValueViewAPI; updatedExtensionConfigDTOwith Ignite 3.x@Column/@Idannotations; rewroteIgniteStoreServerto use synchronous embeddedIgnite.start()node APItika-grpc: Addedemitter_idfield toFetchAndParseRequestproto; updatedTikaGrpcServerImplwith properIgniteStoreServerlifecycle; added required--add-opensJVM flags for Java 17+tika-pipes-core/EmitHandler: Fixed NPE — added null check forNO_EMITscenario before attempting emissiontika-parent/pom.xml: Added Ignite 3.x convergence entries forasm,picocli,snakeyaml,javax.validationIgniteConfigStoreTestto use sharedIgniteStoreServervia@BeforeAll/@AfterAll(Ignite 3.x embedded server pattern)Review Focus Areas
IgniteConfigStore—IgniteCachereplaced byKeyValueView; verify CRUD semantics are preservedTikaGrpcServerImplNO_EMIT/ null emitter IDtika-parentfor Ignite 3.x transitive conflictsCritical Files
tika-pipes/tika-pipes-config-store-ignite/src/main/java/org/apache/tika/pipes/ignite/IgniteConfigStore.javatika-pipes/tika-pipes-config-store-ignite/src/main/java/org/apache/tika/pipes/ignite/server/IgniteStoreServer.javatika-grpc/src/main/java/org/apache/tika/pipes/grpc/TikaGrpcServerImpl.javatika-pipes/tika-pipes-core/src/main/java/org/apache/tika/pipes/core/server/EmitHandler.javaTesting Instructions
Related