TIKA-4606: Add e2e tests for Ignite 3.x upgrade#2649
Open
nddipiazza wants to merge 2 commits intomainfrom
Open
TIKA-4606: Add e2e tests for Ignite 3.x upgrade#2649nddipiazza wants to merge 2 commits intomainfrom
nddipiazza wants to merge 2 commits intomainfrom
Conversation
- Upgraded ignite-core 2.16.0 to ignite-runner 3.1.0 - Migrated configuration from IgniteConfiguration API to HOCON-based config files - Updated API usage from IgniteCache to new KeyValueView API - Fixed ExtensionConfigDTO to use Ignite 3.x Mapper annotations - Simplified IgniteStoreServer to synchronous embedded mode - Fixed EmitHandler: added null check for NO_EMIT scenario to prevent NPE - Updated gRPC proto: added emitter_id field to FetchAndParseRequest - Updated TikaGrpcServerImpl: proper lifecycle management for IgniteStoreServer - Added JVM --add-opens flags for Java 17+ compatibility - Updated unit tests (IgniteConfigStoreTest) for Ignite 3.x embedded server pattern Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add tika-e2e-tests module to root pom.xml build - Update tika-e2e-tests parent pom: inherit from tika-parent, add Micronaut version alignment for Ignite 3.x transitive dependencies - Update tika-grpc e2e pom: local server mode by default (tika.e2e.useLocalServer=true), add Awaitility dependency, disable enforcer for Ignite 3.x dep conflicts - Add tika-config-ignite-local.json for local server mode testing - Update ExternalTestBase and IgniteConfigStoreTest for local vs Docker switching - Add FileSystemFetcherTest e2e test Note: these tests require the Ignite 3.x core upgrade from TIKA-4606-ignite-core. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
tika-e2e-testsmodule to the parent build and updates the gRPC e2e test suite to work with the Ignite 3.x upgrade from #2648.Changes
pom.xml: Added<module>tika-e2e-tests</module>tika-e2e-tests/pom.xml: Inherit fromtika-parent; added Micronaut version alignment for Ignite 3.x transitive deps; pinnedtestcontainersto 2.0.3; added Apache RAT excludestika-e2e-tests/tika-grpc/pom.xml: Default to local server mode (tika.e2e.useLocalServer=true— no Docker needed in CI); added Awaitility; disabled enforcer for Ignite 3.x transitive dep conflictstika-config-ignite-local.json: New config for local (non-Docker) server modeExternalTestBase: Conditional logic to start a localTikaGrpcServervs spin up a Docker containerIgniteConfigStoreTest(e2e): Full e2e flow using the gRPC channel against local serverFileSystemFetcherTest: e2e test for filesystem fetcher through gRPC pipelineReview Focus Areas
ExternalTestBase— conditional branching ontika.e2e.useLocalServerproperty@AfterAll-Dtika.e2e.useLocalServer=falseCritical Files
tika-e2e-tests/tika-grpc/src/test/java/org/apache/tika/pipes/ExternalTestBase.javatika-e2e-tests/tika-grpc/src/test/java/org/apache/tika/pipes/ignite/IgniteConfigStoreTest.javatika-e2e-tests/tika-grpc/pom.xmlTesting Instructions
Related