Skip to content

feat(frontend): pin an operator's result beside it, with a tab per output port - #9063

Draft
kz930 wants to merge 4 commits into
apache:mainfrom
kz930:feat/9062-pinned-result-windows
Draft

kz930 wants to merge 4 commits into
apache:mainfrom
kz930:feat/9062-pinned-result-windows

Conversation

@kz930

@kz930 kz930 commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

The hover card gets a Pin button. Pinning turns it into a window beside the operator with the whole result table, tied to the operator by a dashed line. Several windows can be open at once; each can be dragged and resized, and follows its operator when it or the canvas moves.

An operator with more than one output gets a tab per output port in its window. The first port is the one the running execution reports on; another port is read when its tab is shown, through the port-aware result service from #9054, and pages by the row count its replies carry. The table in a window fills the window: it measures the space its search bar, header, statistics row and pager take, and fits as many rows as are left. It shows its statistics row only when a column has statistics, which another port never has.

pr3-2-pinned-output-1 pr3-3-pinned-output-2

This needs #9058, so the diff includes its commit and #9054's until they merge. The PR's own change is the last commit.

Any related issues, documentation, discussions?

Closes #9062. Part of #9052. Design discussed in #8842.

How was this PR tested?

A new spec for the pinned window covers its port tabs, the port it shows and the height it hands the table. New cases in the result table's spec cover filling a given height and the statistics row. The affected frontend specs pass. In the running app, a Split of 20 rows into 13 and 7 shows the first output's 13 rows in its first tab and the other 7 in its second, each paged correctly, and the pager ends near the window's bottom edge at any window size.

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Claude Opus 5.5)

🤖 Generated with Claude Code

Every external output port of an operator that keeps its result is
stored, but results were only ever read from the first port, so a
Split's second output or an If's True branch could not be shown.

A pagination request can now name the output port to read, with the
first port as the default, and the reply carries the port it read and
that port's row count. The live result updates keep following the
first port, so a client paging another port takes the count from the
reply. The result store's count per operator now comes from the first
port too; it was built from every stored port, so a terminal Split's
second output could replace its first output's count.

On the frontend, the result service gives each extra port its own
pagination service, which names its port in its requests, keeps no
page cache and takes its row count from each reply, and every port's
service takes its schema only from replies to its own requests. The
result table and its row detail can show any port.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kz930 and others added 3 commits October 20, 2026 16:37
Switching the table to another output port left the previous port's
rows on screen when the new port was empty, with the loading state
never ending, and a late reply for the previous port could replace the
new port's rows. A port change now starts from an empty table, a reply
for an operator or port no longer shown is dropped, and an empty page
ends the loading.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…canvas

Resting the pointer on an operator for half a second shows a card
beside it with the operator's first rows and its size, or its error,
or how to keep a result the run did not keep. A pointer passing over,
dragging, or a click opens nothing, and the card lingers a moment so
the pointer can move into it. An operator with several outputs says
the rows are the first output's. The preview can be turned off under
Layers, and stays off while the heat-map overlay is on.

The first rows come from a request of their own, so a preview never
moves the result table's page or reads its cache.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tput port

Pinning the hover card opens a window beside the operator with its
whole result table, tied to it by a dashed line. Several windows can
be open at once; each can be dragged and resized, and follows its
operator when the operator or the canvas moves.

An operator with more than one output gets a tab per output port in
its window. The first port is the one the running execution reports
on; another port is read through the port-aware result service when
its tab is shown.

The table in a window measures what it draws around its rows, the
search bar, header, statistics and pager, and fits as many rows as
the rest of the window allows, so the pager sits near the window's
bottom at any size. The bottom panel keeps its own rule. The
statistics row shows only when a column has statistics, which a port
past the first never has.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kz930
kz930 force-pushed the feat/9062-pinned-result-windows branch from 09f2b2d to 896a32a Compare October 20, 2026 23:40
@kz930

kz930 commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author

@carloea2 could you take a look at this when you have a chance? It stays a draft until #9058 merges, but its own change, the last commit, is ready for review.

@github-actions

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • Contributors with relevant context: @yangzhang75, @aglinxinyuan, @Ma77Ball
    You can notify them by mentioning @yangzhang75, @aglinxinyuan, @Ma77Ball in a comment.

@codecov-commenter

codecov-commenter commented Oct 21, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 67.02997% with 121 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.18%. Comparing base (22b82a2) to head (896a32a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...onent/workflow-editor/workflow-editor.component.ts 48.10% 36 Missing and 5 partials ⚠️
...-result-window/pinned-result-window.component.html 0.00% 29 Missing ⚠️
...ed-result-window/pinned-result-window.component.ts 52.08% 18 Missing and 5 partials ⚠️
...ent/workflow-editor/workflow-editor.component.html 44.44% 10 Missing ⚠️
...esult-preview/operator-result-preview.component.ts 89.39% 0 Missing and 7 partials ⚠️
...result-table-frame/result-table-frame.component.ts 91.30% 0 Missing and 4 partials ⚠️
...c/app/workspace/component/menu/menu.component.html 50.00% 2 Missing ⚠️
...ult-preview/operator-result-preview.component.html 95.34% 1 Missing and 1 partial ⚠️
...ervice/workflow-graph/model/joint-graph-wrapper.ts 60.00% 2 Missing ⚠️
...src/app/workspace/component/menu/menu.component.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9063      +/-   ##
============================================
- Coverage     92.33%   92.18%   -0.16%     
+ Complexity     5045     5044       -1     
============================================
  Files          1261     1265       +4     
  Lines         54120    54462     +342     
  Branches       6768     6830      +62     
============================================
+ Hits          49974    50207     +233     
- Misses         2486     2566      +80     
- Partials       1660     1689      +29     
Flag Coverage Δ *Carryforward flag
access-control-service 77.38% <ø> (ø) Carriedforward from a64630b
agent-service 99.16% <ø> (ø) Carriedforward from a64630b
amber 87.31% <ø> (-0.01%) ⬇️ Carriedforward from a64630b
computing-unit-managing-service 60.48% <ø> (ø) Carriedforward from a64630b
config-service 87.37% <ø> (ø) Carriedforward from a64630b
file-service 82.00% <ø> (ø) Carriedforward from a64630b
frontend 96.16% <67.02%> (-0.40%) ⬇️
notebook-migration-service 83.73% <ø> (ø) Carriedforward from a64630b
pyamber 98.57% <ø> (ø) Carriedforward from a64630b
workflow-compiling-service 72.43% <ø> (ø) Carriedforward from a64630b

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine feature frontend Changes related to the frontend GUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pin an operator's result beside it, with a tab per output port

2 participants